Fix operator declaraion lambda IDs #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
changed the title
bugarela
approved these changes
Dec 1, 2023
Comment on lines
+73
to
+92
| [7n, '(bool) => int'], | ||
| [8n, 'bool'], | ||
| [9n, 'bool'], | ||
| [10n, 'int'], | ||
| [11n, 'bool'], | ||
| [12n, 'bool'], | ||
| [13n, 'int'], | ||
| [14n, 'int'], | ||
| [15n, '((bool) => int, bool) => int'], | ||
| [16n, '((bool) => int, bool) => int'], | ||
| [1n, '∀ t0, t1 . (t0) => t1'], | ||
| [2n, '∀ t0 . t0'], | ||
| [3n, '∀ t0 . t0'], | ||
| [4n, '∀ t0 . t0'], | ||
| [5n, '∀ t0, t1 . ((t0) => t1, t0) => t1'], | ||
| [6n, '(bool) => int'], | ||
| [7n, 'bool'], | ||
| [8n, 'bool'], | ||
| [9n, 'int'], | ||
| [10n, 'bool'], | ||
| [11n, 'bool'], | ||
| [12n, 'int'], | ||
| [13n, 'int'], | ||
| [14n, '((bool) => int, bool) => int'], | ||
| [6n, '∀ t0, t1 . ((t0) => t1, t0) => t1'], |
There was a problem hiding this comment.
These ids have a weird order (7-16, then 1-6). I guess if you feel like fixing, nice, otherwise its fine as well, this is not important.
There was a problem hiding this comment.
I will. Or mess with it so long as the tests are passing. I wonder why the order is that way!
added 5 commits
December 1, 2023 07:47
The lambda's on the right side of operator definitions where getting assigned the same IDs as operator declaration itself, violating our expectation that every IR component will have a uniqe id.
shonfeder
force-pushed
the
fix-oper-lambda-ids
branch
from
634c490 to
d0bc358
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to discussion with @bugarela, following the review comment at
#1277 (comment) , we
realized that the lambdas constructed for the body of an operator
defdeclaration where using the wrong ID (they where reusing the IDs from the
declaration as a whole). But every IR component is meant to have its own ID, so
this is incorrect.
CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality