feat: integrate ics23 in cometbft client contract #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-integrate-ics23
…to-integrate-ics23
…to-integrate-ics23
…nel` (#381) * Implement ProtoMessage encoding for ConnectionEnd * Use encode_repeated_field for version in Connectionend ProtoMessage * Implement ProtoMessage encoding for ChannelEnd * Implement Into StateValue * Add test for CommitmentProof decoding * Update test_commitment_decode in Cairo * scarb fmt in cairo-libs * Add encode and decode test for CommitmentProof * Add felt252_to_u8_array implementation to ICS23 Cairo utils * WIP: fix Connection Open Ack proof verification * Fix commitment verification * Use MockClient instead of CometClient for Cairo tests * Remove assert_owner from TokenTransfer contract * Optimisations in cairo-contracts * Optimisations in cairo-libs * Cleanup * Optimise while loops * use starknet-devnet with higher gas limit * Fix compilation error due to return value in loop * Fix Starknet Store custom implementations * Implement verify_non_membership * Fix ICS23 verify_non_membership implementation * Implement i128 protobuf encoding and decoding * Fix ArrayAsProtoMessage encode_raw * Replace while i != len * Improve lexicographical_cmp loop * Format long arrays in tests * refactor next_power_of_two * Replace encode and decode u64 from to bytearray with u128 --------- Co-authored-by: Ranadeep Biswas <[email protected]>
rnbguy
changed the title
rnbguy
added a commit
that referenced
this pull request
Apr 16, 2025
* Update relayer to integrate ICS23 * taplo fix * Fix build_packet_from_send_packet_event * Clean-up * feat: integrate ics23 in cometbft client contract (#378) * Update Cairo contracts and libs to use ICS23 * taplo fix * Fix Cairo warnings and test * scarb fmt * Temporary STATE_PROOF() implementation * feat: implement `ProtoMessage` encoding for `ConnectionEnd` and `Channel` (#381) * Implement ProtoMessage encoding for ConnectionEnd * Use encode_repeated_field for version in Connectionend ProtoMessage * Implement ProtoMessage encoding for ChannelEnd * Implement Into StateValue * Add test for CommitmentProof decoding * Update test_commitment_decode in Cairo * scarb fmt in cairo-libs * Add encode and decode test for CommitmentProof * Add felt252_to_u8_array implementation to ICS23 Cairo utils * WIP: fix Connection Open Ack proof verification * Fix commitment verification * Use MockClient instead of CometClient for Cairo tests * Remove assert_owner from TokenTransfer contract * Optimisations in cairo-contracts * Optimisations in cairo-libs * Cleanup * Optimise while loops * use starknet-devnet with higher gas limit * Fix compilation error due to return value in loop * Fix Starknet Store custom implementations * Implement verify_non_membership * Fix ICS23 verify_non_membership implementation * Implement i128 protobuf encoding and decoding * Fix ArrayAsProtoMessage encode_raw * Replace while i != len * Improve lexicographical_cmp loop * Format long arrays in tests * refactor next_power_of_two * Replace encode and decode u64 from to bytearray with u128 --------- Co-authored-by: Ranadeep Biswas <[email protected]> --------- Co-authored-by: Ranadeep Biswas <[email protected]> * Correctly handle errors when decoding struct related to proof specs --------- Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently a work in progress.
Status
Update Cairo contract by adding a
Array<ProofSpec>field to Comet client state and requiredstarknet::Storeimplementations.Use ICS23 implementation for Comet client
verify_membership