fix(comet): Revert syncing to head change, seems unreliable. (beracha…

…in#1369)

x

mod/beacon/blockchain/metrics.go

@@ -21,7 +21,6 @@
 package blockchain
 
 import (
-	"strconv"
 	"time"
 
 	"github.com/berachain/beacon-kit/mod/primitives/pkg/math"
@@ -45,13 +44,11 @@ func newChainMetrics(
 // measureStateTransitionDuration measures the time to process
 // the state transition for a block.
 func (cm *chainMetrics) measureStateTransitionDuration(
-	start time.Time, skipPayloadVerification bool,
+	start time.Time,
 ) {
 	cm.sink.MeasureSince(
 		"beacon_kit.beacon.blockchain.state_transition_duration",
 		start,
-		"skip_payload_verification",
-		strconv.FormatBool(skipPayloadVerification),
 	)
 }
 

mod/beacon/blockchain/process.go

@@ -73,7 +73,6 @@ func (s *Service[
 	ctx context.Context,
 	blk BeaconBlockT,
 	sidecars BlobSidecarsT,
-	syncedToHead bool,
 ) ([]*transition.ValidatorUpdate, error) {
 	var (
 		g, gCtx    = errgroup.WithContext(ctx)
@@ -94,7 +93,7 @@ func (s *Service[
 		// ends up not being valid later, the node will simply AppHash,
 		// which is completely fine. This means we were syncing from a
 		// bad peer, and we would likely AppHash anyways.
-		valUpdates, err = s.processBeaconBlock(gCtx, st, blk, syncedToHead)
+		valUpdates, err = s.processBeaconBlock(gCtx, st, blk)
 		return err
 	})
 
@@ -147,10 +146,9 @@ func (s *Service[
 	ctx context.Context,
 	st BeaconStateT,
 	blk BeaconBlockT,
-	syncedToHead bool,
 ) ([]*transition.ValidatorUpdate, error) {
 	startTime := time.Now()
-	defer s.metrics.measureStateTransitionDuration(startTime, syncedToHead)
+	defer s.metrics.measureStateTransitionDuration(startTime)
 	valUpdates, err := s.sp.Transition(
 		&transition.Context{
 			Context:          ctx,
@@ -168,7 +166,7 @@ func (s *Service[
 			// of validators in their process proposal call and thus
 			// the "verification aspect" of this NewPayload call is
 			// actually irrelevant at this point.
-			SkipPayloadVerification: syncedToHead,
+			SkipPayloadVerification: false,
 		},
 		st,
 		blk,

mod/runtime/pkg/runtime/middleware/finalize.go

@@ -136,7 +136,10 @@ func (h *FinalizeBlockMiddleware[
 	// Process the state transition and produce the required delta from
 	// the sync committee.
 	h.valUpdates, err = h.chainService.ProcessBlockAndBlobs(
-		ctx, blk, blobs, req.SyncingToHeight == req.Height,
+		ctx, blk, blobs,
+		// TODO: Speak with @melekes about this, doesn't seem to
+		// work reliably.
+		/*req.SyncingToHeight == req.Height*/
 	)
 	return err
 }

mod/runtime/pkg/runtime/middleware/types.go

@@ -52,7 +52,6 @@ type BlockchainService[
 		context.Context,
 		BeaconBlockT,
 		BlobSidecarsT,
-		bool,
 	) ([]*transition.ValidatorUpdate, error)
 
 	// ReceiveBlockAndBlobs receives a beacon block and