fix: fix invalid typehints for Point, add missing typehints fo BatchItemKey - #177
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
============================================
- Coverage 75.09% 74.86% -0.23%
- Complexity 455 461 +6
============================================
Files 25 25
Lines 1104 1110 +6
============================================
+ Hits 829 831 +2
- Misses 275 279 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Roman3349
force-pushed
the
fix/point-typehints
branch
from
July 27, 2026 23:16
9cfd22f to
4521773
Compare
Roman3349
marked this pull request as draft
July 28, 2026 09:07
…ItemKey Co-authored-by: Alexandre Bertrand <alexandre.bertrand@invirtus.io> Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
Roman3349
force-pushed
the
fix/point-typehints
branch
from
July 28, 2026 09:48
4521773 to
5774b7f
Compare
Roman3349
marked this pull request as ready for review
July 28, 2026 09:48
karel-rehor
self-requested a review
July 28, 2026 11:13
karel-rehor
approved these changes
Jul 28, 2026
karel-rehor
left a comment
karel-rehor
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this!
Looks good to me. 🚴 🏁
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes typehints in
Pointclass and adds typehints forBatchItemKeyclass.Should supersede stale PR #148 which now requires rebase to merge.
Checklist
- [ ] A test has been added if appropriatemake testcompletes successfully