Skip to content

feat(tests): add PHPStan and typehints to tests - #176

Merged
karel-rehor merged 2 commits into
influxdata:masterfrom
Roman3349:feature/php7.2-typehints
Jul 28, 2026
Merged

feat(tests): add PHPStan and typehints to tests#176
karel-rehor merged 2 commits into
influxdata:masterfrom
Roman3349:feature/php7.2-typehints

Conversation

@Roman3349

@Roman3349 Roman3349 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Adds PHPStan, fix PHPUnit calls and add missing typehints in tests.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
    - [ ] A test has been added if appropriate
  • make test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
@codecov-commenter

codecov-commenter commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (3ecd2ba) to head (600f7f7).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage     75.09%   75.09%           
  Complexity      455      455           
=========================================
  Files            25       25           
  Lines          1104     1104           
=========================================
  Hits            829      829           
  Misses          275      275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>

@karel-rehor karel-rehor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Romane, thanks once again for this useful contribution!

Looks good to me. 🚴 🏁

@karel-rehor
karel-rehor merged commit fc8f072 into influxdata:master Jul 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants