Skip to content

Conversation

@erratic-pattern
Copy link

@erratic-pattern erratic-pattern commented Dec 6, 2025

Previous revision: #81

Context:
This revision re-enables the aggregate physical schema check so that a fix can be found and deployed.

Current status of the investigation and fix: In-Progress by @erratic-pattern

Included Patches

  1. All patches from Patched DF 49.0.2 (revision c)  #78 except those that have been removed (see below)

Removed Patches

  1. disable skip_physical_aggregate_shcema_check and log warning but do not error (4e7ad0d)

crepererum and others added 5 commits November 10, 2025 10:52
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.

test: recreating the iox plan:
* demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning

test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution

fix: special case to not remove the needed coalesce
* test: reproducer of bug
* fix: make schema names unique for approx_percentile_cont
* test: regression test is now resolved
…8709)

Closes apache#18692 (hopefully)

Trying to get CI to pass consistently, try various techniques.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants