Added bindgen as build dependency for nj-sys #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not actually sure the best way to fix CI for this PR. With Ubuntu and macOS, apt and brew would work in CI but I'm not super well versed in the package managers windows has. It looks like chocolatey has a github action we could use to install llvm. This issue brings to light the need for an external dependency. Thoughts? |
|
Now come to think of it, this is probably biggest issue. It force developers to use install LLVM which is not easy. It took me 10 hour to install from source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in #97, adding bindgen as a build dependency was brought up and as it really doesn't require any of the features in #97, I figure it's best to make in a separate PR so we can benchmark and see the differences easily.
One thing I've noticed is that the bindings are actually different in Linux vs on macOS. Here's the differences. The tests all still pass though.
I compared these changes on my archlinux desktop that has i7 with 8 cores and 16gb of ram and the build time for
cargo build --workspacewent from 25 seconds to 30 seconds.