Skip to content

add delete reference method to JsEnv, invoke delete_refence on wrapped reference #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

add delete reference method to JsEnv, invoke delete_refence on wrapped reference #55

merged 1 commit into from
Jul 31, 2020

Conversation

Ryanmtate
Copy link
Contributor

@Ryanmtate Ryanmtate commented Jul 30, 2020 •
edited
Loading

This is a draft PR to resolve #53

@Ryanmtate Ryanmtate force-pushed the bugfix/njcore/class branch 2 times, most recently from 9cce219 to 4e76f29 Compare July 31, 2020 16:07
@Ryanmtate Ryanmtate force-pushed the bugfix/njcore/class branch from 4e76f29 to 9570015 Compare July 31, 2020 16:08
@Ryanmtate Ryanmtate marked this pull request as ready for review July 31, 2020 16:08
@Ryanmtate Ryanmtate mentioned this pull request Jul 31, 2020
Closed
@Ryanmtate Ryanmtate changed the title remove box from_raw deallocation in js_finalize add delete reference method to JsEnv, invoke delete_refence on wrapped … 9570015 reference Jul 31, 2020
@Ryanmtate Ryanmtate changed the title add delete reference method to JsEnv, invoke delete_refence on wrapped … 9570015 reference add delete reference method to JsEnv, invoke delete_refence on wrapped reference Jul 31, 2020
sehz
sehz approved these changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! I think this is a right solution

@sehz sehz merged commit f1631b3 into infinyon:support_v14 Jul 31, 2020
@sehz sehz linked an issue Jul 31, 2020 that may be closed by this pull request
malloc error on shutdown #53
Closed
@Ryanmtate Ryanmtate mentioned this pull request Jul 31, 2020
Merged
sehz pushed a commit that referenced this pull request Aug 1, 2020
@Ryanmtate @sehz
add delete reference method to JsEnv, invoke delete_refence on wrapped (
8b5918f 
#55)

reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

malloc error on shutdown
2 participants
@Ryanmtate @sehz