Taking it further #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 20, 2015 14:19
introduces subclasses of Movie
it is possible for a movie to change its type during its lifetime, from 'new release' to 'regular', for example subclassing based on movie type doesn't allow for such change as we cannot change the class of an object to represent type change hence the implementation of PriceCode and its subclasses
makes use of existing polymorphism to minimise control flow
this data is not used anywhere it was useful for control flow before polymorphism was applied
|
This builds up on the re-write version of the solution and improves polymorphism implementation to reflect the fact that in real store a movie can change its type during its lifetime (from new release to regular for example), therefore representing such type with subclass would limit this ability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves polymorphism from Movie to PriceCode