-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fourier-transform to benchmarks #3
Conversation
Thanks for opening this! Let's wait until this lib will support all-real-input mode before adding this benchmark. Btw, numbers are not so distant now with the latest changes 😉
|
Regarding tests - I'm cross testing against |
Here is the link FWIW: Lines 140 to 157 in 28cfc12
|
👍
Ok, but... what is all-real-input mode?
I see... good work!
Great! I've updated the PR to your master and fix a couple of eslint errors. |
The input for FFT is generally an array of complex values. However, if all of these values are actually real numbers - we can compute significantly less because of various constraints on the output. |
Implemented |
I've added the fourier-transform to the benchmark (related to #1). It seems to be the fastest but is unfair because only works with real signals and have no inverse operation.
This is the results of the benchmark in my computer:
Thanks for the library, the code looks very clean and easy to understand (and I've read a lot of implementations lately). Looking forward #2 to improve speed. And probably is a good idea to have some tests to check the results (it looks like different implementations have slightly different values)
Congrats.