Support subclass fields in dataclass_array_container#333
Merged
inducer merged 4 commits intoinducer:mainfrom Jul 31, 2025
Merged
Support subclass fields in dataclass_array_container#333inducer merged 4 commits intoinducer:mainfrom
inducer merged 4 commits intoinducer:mainfrom
Conversation
Owner
|
Thanks! Added a test of sorts, plus some other coincidental typing stuff. |
Collaborator
Author
Thanks for adding the test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_annotationsonly gets annotations from the current class, but not from any subclasses. This extends that by going through the MRO (in reverse) and gathering all of them up.Context:
boxtree.Treeinherits fromboxtree.TreeOfBoxesand this wouldn't recognize the fields fromTreeOfBoxes, which are still in the list returned byfields(Tree).