map: Make Eq comparisons ordering-aware. #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. Not sure if you really want to take this but I think it's the right thing to do. Fixes indexmap-rs#153
I've added it to #135 to consider for 2.0. In the meantime, we could add a method for map1.len() == map2.len() && map1.iter().eq(&map2) |
|
Yup, agree, That seems reasonable, thank you! |
|
Do you want to leave this PR open? Or should I close it? |
|
Let's close -- it will be here when we're ready for 2.0, but that's not really happening yet. |
bluss
reviewed
Sep 9, 2020
| assert_eq!(&set_a ^ &set_b, set_c); | ||
| assert_eq!(&set_b ^ &set_a, set_c); | ||
| assert_ne!(&set_b ^ &set_a, set_c); |
There was a problem hiding this comment.
when this is revived later, this change does not preserve the intent of the test. It can of course be fleshed out when/if relevant later.
|
Thanks for filing. Not a bug since it's the intentional design, but worth discussing for sure. I think a method for ordered eq would be worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change. Not sure if you really want to take this but
I think it's the right thing to do.