Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWF-101: Use different structures for WorkflowStateOptions #283

Merged
merged 19 commits into from
Dec 19, 2024
Merged

IWF-101: Use different structures for WorkflowStateOptions #283

merged 19 commits into from
Dec 19, 2024

Conversation

stevo89519
Copy link
Contributor

@stevo89519 stevo89519 commented Dec 17, 2024 •
edited by longquanzheng
Loading

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is NOT backwards-compatible)

Related Issue

Closes #<issue_number>

longquanzheng
longquanzheng reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more minor comments and found a bug in the previous code(not from you). Otherwise lgtm (great job, this is quite some refactoring)!

src/main/java/io/iworkflow/core/WorkflowStateOptions.java Show resolved Hide resolved
src/main/java/io/iworkflow/core/WorkflowStateOptions.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java Outdated Show resolved Hide resolved
longquanzheng
longquanzheng reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. I promise this is the last run like this 😂

src/main/java/io/iworkflow/core/WorkflowStateOptions.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/WorkflowStateOptions.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java Show resolved Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java Outdated Show resolved Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java Outdated Show resolved Hide resolved
longquanzheng
longquanzheng approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@stevo89519 stevo89519 merged commit 8d03c15 into main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixydubs mixydubs mixydubs left review comments

@longquanzheng longquanzheng longquanzheng approved these changes

@lwolczynski lwolczynski Awaiting requested review from lwolczynski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevo89519 @longquanzheng @mixydubs @lwolczynski