Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new benchmark results for the NVIDIA H100 80GB HBM3 GPU. It offers detailed performance metrics for dense matrix multiplication, exploring a diverse array of quantization strategies and data types. The addition of these benchmarks provides valuable insights into the efficiency of different numerical precision configurations and underlying libraries on the H100 architecture, which is essential for optimizing deep learning workloads. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new JSON files containing benchmark results for various configurations under benchmarks/results/h100/dense_n8192_k8192_g0/. These files detail problem specifications, device information, package versions, and performance metrics (time, memory_gbps, compute_tops) across different batch sizes. A consistent issue identified in the review is that all newly added JSON files are missing a final newline character, which is a good practice for consistency and adherence to POSIX standards.
benchmarks/results/h100/dense_n8192_k8192_g0/cutlass_w8a8_float8e4m3_float16.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/humming_w1a16_int1_float16.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/humming_w1a8_int1_float8e4m3.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/humming_w2a16_int2_float16.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/humming_w2a8_int2_float8e4m3.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/humming_w8a8_float8e4m3_float8e4m3.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/marlin_w4a16_int4_float16.json
Show resolved
Hide resolved
benchmarks/results/h100/dense_n8192_k8192_g0/marlin_w8a16_float8e4m3_float16.json
Show resolved
Hide resolved
|
Thanks! I've optimized the performance on H100/H200, and now Humming's performance is on par with or even exceeds Torch and CUTLASS. |
Kernel Benchmarks