Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package dhcurve to inbo_software (issue #183) #293

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

ElsLommelen
Copy link
Contributor

Description

I added a link and a description of package dhcurve to the webpage of INBO software.
Package is in collaboration with @ThierryO and @leymanan

Related Issue

Part of #183

Task list

  • My tutorial or article is placed in a subfolder of tutorials/content
  • The filename of my tutorial or article is index.md. In case of an Rmarkdown tutorial I have knitted my index.Rmd to index.md (both files are pushed to the repo).
  • I have included tags in the YAML header (see the tags listed in the tutorials website side bar for tags that have been used before)
  • I have added categories to the YAML header and my category tags are from the list of category tags

Previewing the pull request

Thanks to GitHub Actions, an artifact (=zip file) of the rendered website is automatically created for each pull request.

Instructions

  1. On the PR page, you can find a "details" link under "checks - On PR, build the site and ...". Go there, click on the top link in the left sidebar ("Summary"), and download the generated artifact at the bottom of the page.
  2. Decompress it and make sure the target directory is called 'tutorials' (you may need to rename it)
  3. From the parent directory (just above the tutorials folder you created/renamed), run python -m http.server 8887, or launch the Google Chrome Web Server app and point it at the parent directory.
  4. Point your browser to http://localhost:8887/tutorials.
  5. Review the updated website and accept/refuse/comment the PR

Note: for step 3, you can use any other simple HTTP server to serve the current directory if you don't have a Python 3 environment or Google Chrome available.

@ThierryO
Copy link
Contributor

Maybe at the package to https://github.com/inbo/universe too.

@florisvdh
Copy link
Member

@ElsLommelen For now (perhaps awaiting #261 before merging): can you merge master in add-dhcurve (git checkout add-dhcurve && git merge --no-ff master) and push the new commit? That could solve the failed check; the add-dhcurve branch is relatively old.

@ElsLommelen
Copy link
Contributor Author

@florisvdh oups, I did this locally before making this PR, but I forgot to push the commits... :-(

@florisvdh
Copy link
Member

Excellent, thanks.

@peterdesmet
Copy link
Member

This can be merged. I'll resolve conflicts in #261.

@peterdesmet peterdesmet merged commit 22c6109 into master Jan 27, 2022
@peterdesmet peterdesmet deleted the add-dhcurve branch January 27, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants