12.x [BUGFIX] file uploads without file extension might cause exception #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a file without extension is uploaded (e.g. a filename without a dot, like "pdf") an exception occurs, in all other cases a graceful false generates clear error messages. This simple fix should prevent the exception.
jpmschuler
changed the title
mschwemer
added a commit
that referenced
this pull request
Sep 5, 2025
(and update phpstan baseline with reduced errors) Related: #1247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a file without extension is uploaded (e.g. a filename without a dot, like "pdf") an exception occurs, in all other cases a graceful false generates clear error messages. This simple fix should prevent the exception.
(The typical configuration for allowed file extensions in the form is ignored by some browsers, thus resulting in such files being selectable).