Merge pull request #27 from VelaSam/improvement-favorite-button

removed new badge from favorite button + aesthetic detail
imrashb · May 27, 2024 · aacdb90 · aacdb90
2 parents 7bd126a + b05687f
commit aacdb90
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/components/NavBar/NavBar.jsx b/src/components/NavBar/NavBar.jsx
@@ -77,7 +77,7 @@ export default function NavBar() {
                     label={isSmallViewport ? undefined : (
                       <>
                         {t(tab.label)}
-                        {tab.new && <NewBadge />}
+                        {tab.new}
                       </>
                     )}
                   />

diff --git a/src/pages/GenerateurHoraire/Combinaisons/FavoriteButton.jsx b/src/pages/GenerateurHoraire/Combinaisons/FavoriteButton.jsx
@@ -1,4 +1,4 @@
-import { Favorite } from '@mui/icons-material';
+import { Favorite, FavoriteBorder } from '@mui/icons-material';
 import { Badge, IconButton } from '@mui/material';
 import React from 'react';
 import { arrayRemove, arrayUnion, setDoc } from 'firebase/firestore';
@@ -39,16 +39,12 @@ function FavoriteButton({ combinaison }) {
   };
 
   return (
-    <Badge badgeContent={t('badgeNew')} color="badgeNew">
-      {' '}
-      <IconButton
-        color={isFavorited ? 'primary' : undefined}
-        onClick={handleFavorite}
-      >
-        <Favorite />
-      </IconButton>
-    </Badge>
-
+    <IconButton
+      color={isFavorited ? 'primary' : undefined}
+      onClick={handleFavorite}
+    >
+      {isFavorited ? <Favorite /> : <FavoriteBorder />}
+    </IconButton>
   );
 }