Skip to content

Commit ce28009

Browse files
committed
fix: applied pr suggestions
1 parent d67252c commit ce28009

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

sample/Assets/Scenes/AuthenticatedScene.unity

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1619,7 +1619,7 @@ MonoBehaviour:
16191619
m_HorizontalOverflow: 0
16201620
m_VerticalOverflow: 0
16211621
m_LineSpacing: 1
1622-
m_Text: Get Receipt
1622+
m_Text: Get Status
16231623
--- !u!222 &262502330
16241624
CanvasRenderer:
16251625
m_ObjectHideFlags: 0

sample/Assets/Scripts/AuthenticatedScript.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,9 +410,11 @@ public async void GetZkTransactionReceiptStatus()
410410
{
411411
try
412412
{
413-
ShowOutput($"Getting zkEVM transaction receipt...");
413+
ShowOutput($"Getting zkEVM transaction receipt status...");
414+
414415
TransactionReceiptResponse response = await passport.ZkEvmGetTransactionReceipt(ZkGetTransactionReceiptHash.text);
415-
ShowOutput($"Transaction receipt status: {response.status}");
416+
ShowOutput($"Transaction receipt status: {(response.status == "0x1" ? "Success" : "Failed")}");
417+
416418
}
417419
catch (Exception ex)
418420
{

src/Packages/Passport/Runtime/Scripts/Private/Model/Response/TransactionReceiptResponse.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ public class TransactionReceiptResponse
2020

2121
public string logsBloom;
2222

23+
/// <summary>
24+
/// Either 1 (success) or 0 (failure) encoded as a hexadecimal.
25+
/// </summary>
2326
public string status;
2427

2528
public string to;

src/Packages/Passport/Runtime/Scripts/Private/PassportImpl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ public async UniTask<string> ZkEvmSendTransaction(TransactionRequest request)
703703
return callResponse.GetStringResult();
704704
}
705705

706-
public async UniTask<TransactionReceiptResponse?> ZkEvmGetTransactionReceipt(string hash)
706+
public async UniTask<TransactionReceiptResponse> ZkEvmGetTransactionReceipt(string hash)
707707
{
708708
string json = JsonUtility.ToJson(new TransactionReceiptRequest()
709709
{

src/Packages/Passport/Runtime/Scripts/Public/Passport.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,9 +334,10 @@ public async UniTask<string> ZkEvmSendTransaction(TransactionRequest request)
334334
}
335335

336336
/// <summary>
337-
/// Returns a sent/submitted transaction status information
337+
/// Retrieves the transaction information of a given transaction hash. This function uses the Ethereum JSON-RPC <c>eth_getTransactionReceipt</c> method.
338338
/// <returns>
339-
/// The receipt of transaction, or null if the transaction is still in process
339+
/// The receipt of the transaction or null if it is still processing.
340+
340341
/// </returns>
341342
/// </summary>
342343
public async UniTask<TransactionReceiptResponse> ZkEvmGetTransactionReceipt(string hash)

0 commit comments

Comments
 (0)