Merge pull request #186 from immutable/fix/nullables-unity-2019

[DX-2793] fix: nullables not working for unity 2019

Author: nattb8

src/Packages/Passport/Runtime/Scripts/Private/Event/AnalyticsEvent.cs

@@ -42,7 +42,7 @@ public static class Properties
         }
 
         public async UniTask Track(IBrowserCommunicationsManager communicationsManager, string eventName,
-            bool? success = null, Dictionary<string, object>? properties = null)
+            bool? success = null, Dictionary<string, object> properties = null)
         {
             try
             {

src/Packages/Passport/Runtime/Scripts/Private/PassportImpl.cs

@@ -22,7 +22,7 @@ public class PassportImpl
     {
         private const string TAG = "[Passport Implementation]";
         public readonly IBrowserCommunicationsManager communicationsManager;
-        private PassportAnalytics analytics = new();
+        private PassportAnalytics analytics = new PassportAnalytics();
 
         // Used for device code auth
         private DeviceConnectResponse deviceConnectResponse;
@@ -829,7 +829,7 @@ public void ClearStorage()
         }
 #endif
 
-        protected virtual async void Track(string eventName, bool? success = null, Dictionary<string, object>? properties = null)
+        protected virtual async void Track(string eventName, bool? success = null, Dictionary<string, object> properties = null)
         {
             await analytics.Track(communicationsManager, eventName, success, properties);
         }

src/Packages/Passport/Tests/Runtime/Scripts/PassportTests.cs

@@ -24,7 +24,7 @@ protected override void OpenUrl(string url)
             urlsOpened.Add(url);
         }
 
-        protected override void Track(string eventName, bool? success = null, Dictionary<string, object>? properties = null)
+        protected override void Track(string eventName, bool? success = null, Dictionary<string, object> properties = null)
         {
         }
     }