Skip to content

Commit 128ceef

Browse files
authored
Merge pull request #301 from immutable/feature/sdk-3322-webgl-pkce
[SDK-3322] pkce for webgl only
2 parents c0ad3cd + 61d7735 commit 128ceef

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/workflows/linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
VALIDATE_ALL_CODEBASE: true
5858
DEFAULT_BRANCH: main
5959
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
60-
FILTER_REGEX_EXCLUDE: (.*src/Packages/Passport/Runtime/ThirdParty/.*|.*src/Packages/Passport/Runtime/Resources/.*|.*Plugins/.*|.*src/Packages/Passport/Runtime/Assets/ImmutableAndroid.androidlib/.*|.*src/Packages/Orderbook|.*sample|.*src/Packages/Passport/WebGLTemplates)
60+
FILTER_REGEX_EXCLUDE: (.*src/Packages/Passport/Runtime/ThirdParty/.*|.*src/Packages/Passport/Runtime/Resources/.*|.*Plugins/.*|.*src/Packages/Passport/Runtime/Assets/ImmutableAndroid.androidlib/.*|.*src/Packages/Orderbook|.*sample|.*src/Packages/Passport/WebGLTemplates~)
6161
VALIDATE_MARKDOWN: false
6262
VALIDATE_GITLEAKS: false
6363
VALIDATE_JSCPD: false

sample/Assets/Scripts/SelectAuthMethodScript.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,19 @@ public class SelectAuthMethodScript : MonoBehaviour
1616

1717
void Start()
1818
{
19+
// WebGL does not support Device Code Auth, so we'll use PKCE by default instead.
20+
#if UNITY_WEBGL
21+
UsePKCE();
22+
#else
1923
// Determine if PKCE is supported based on the platform
2024
SampleAppManager.SupportsPKCE = IsPKCESupported();
2125

2226
// If PKCE is not supported, initialise Passport to use Device Code Auth
2327
if (!SampleAppManager.SupportsPKCE)
2428
{
25-
InitialisePassport(logoutRedirectUri: "https://www.immutable.com");
29+
UseDeviceCodeAuth();
2630
}
31+
#endif
2732
}
2833

2934
/// <summary>

0 commit comments

Comments
 (0)