Skip to content

chore: fix some minor issues in comments #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function ClaimWithdrawal({ transaction }: ClaimWithdrawalProps) {
useEffect(() => {
const getWithdrawalTxn = async () => {
if (!tokenBridge || !transaction || transaction.details.current_status?.index === undefined) return;
// get withdrawal transaction from the token bridge by receipient address and index
// get withdrawal transaction from the token bridge by recipient address and index
setLoading(true);
try {
const flowRateWithdrawTxnResponse = await tokenBridge?.getFlowRateWithdrawTx({
Expand Down
2 changes: 1 addition & 1 deletion packages/internal/bridge/sdk/src/lib/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export async function checkReceiver(
} catch {
// no receive or fallback
throw new BridgeError(
`address ${address} is not a valid receipient`,
`address ${address} is not a valid recipient`,
BridgeErrorType.INVALID_RECIPIENT,
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ describe('getUnsignedSwapTxFromAmountOut', () => {
expect(swapParams.recipient).toBe(params.fromAddress);
expect(swap.transaction.to).toBe(TEST_SWAP_PROXY_ADDRESS);
expect(swap.transaction.from).toBe(params.fromAddress);
expect(swap.transaction.value).toBe('0x00'); // // expect 0 native tokens to be transferred
expect(swap.transaction.value).toBe('0x00'); // expect 0 native tokens to be transferred
expect(formatEther(swapParams.amountOut)).toBe('1000.0');
expect(formatTokenAmount(swapParams.amountInMaximum, USDC_TEST_TOKEN)).toBe('104.03'); // amount with slippage and fees applied
expect(swapParams.sqrtPriceLimitX96.toString()).toBe('0');
Expand Down Expand Up @@ -369,7 +369,7 @@ describe('getUnsignedSwapTxFromAmountOut', () => {
expect(swapParams.recipient).toBe(params.fromAddress);
expect(swap.transaction.to).toBe(TEST_ROUTER_ADDRESS);
expect(swap.transaction.from).toBe(params.fromAddress);
expect(swap.transaction.value).toBe('0x00'); // // expect 0 native tokens to be transferred
expect(swap.transaction.value).toBe('0x00'); // expect 0 native tokens to be transferred
expect(formatEther(swapParams.amountOut)).toBe('1000.0');
expect(formatTokenAmount(swapParams.amountInMaximum, USDC_TEST_TOKEN)).toBe('100.1'); // includes slippage
expect(swapParams.sqrtPriceLimitX96.toString()).toBe('0');
Expand Down
2 changes: 1 addition & 1 deletion packages/passport/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ For all IMX workflows, you are required to log in with Passport before you can i
#### ZkEvm workflows

All ZkEvm workflows except `eth_requestAccounts` and `eth_sendTransaction` do not require you to be logged in and can be executed without having a connected Passport wallet. Specifically for `eth_sendTransaction` however, you must call `eth_requestAccounts` first.
Some function calls, such as `eth_gasPrice` and `eth_getBalance` will return a value prefixed by `0x` - these are in hexidecimal format and must be converted to base 10 if you are looking for the actual number.
Some function calls, such as `eth_gasPrice` and `eth_getBalance` will return a value prefixed by `0x` - these are in hexadecimal format and must be converted to base 10 if you are looking for the actual number.

#### Logging out

Expand Down
2 changes: 1 addition & 1 deletion packages/x-client/src/config/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('imxClientConfig', () => {
expect(() => imxClientConfig()).toThrowError('configOptions is required');
});

it('should throw when the Enironment parameter is not a valid Environment', () => {
it('should throw when the Environment parameter is not a valid Environment', () => {
// @ts-expect-error
expect(() => imxClientConfig({ environment: 'invalid' }))
.toThrowError('Invalid environment: invalid');
Expand Down