Skip to content

fix: read longitude and latitude when reverse geocoding is off #17558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

atollk
Copy link
Contributor

@atollk atollk commented Apr 12, 2025

… data when reverse geocoding is disabled. (#17511)

Description

Fixes #17511 by separating the checks for longitude & latitude and geocoding

How Has This Been Tested?

  • Unit tests added

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@bo0tzz bo0tzz changed the title Fixed bug which caused longitude and latitude to be deleted from EXIF… fix: read longitude and latitude when reverse geocoding is off Apr 12, 2025
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@danieldietzler danieldietzler requested a review from jrasm91 April 12, 2025 10:34
@zackpollard zackpollard merged commit 8b00578 into immich-app:main Apr 14, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing an asset removes it's location when reverse geocoding is disabled
5 participants