fix: responsive: timeline glitch and keyboard-accessible scrubber #17556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before: main_glitch.movafter: fix.mov |
|
Noticed a little margin problem on mobile, here's it after the last commit |
alextran1502
approved these changes
Apr 14, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a glitch on mobile - when loading timeline at a certain location, midway down the scrubber, loading the bucket will calculate a layout shift, and then trigger another bucket to load, in a loop, causing many buckets to load, and the scrubber to creep upwards.
This is due to not correctly calculating the positions buckets correctly, and improperly compensating for those.
Additionally, bugs with loss of precision between sub-pixel and full-pixel (and rounding errors) have been fixed. The scrubber is now also keyboard accessible. (Pressing up/down will move to prev/next bucket)