Repository navigation
L 8 question texts can be too long restored - #322
Merged
Merged
Conversation
…ng-restored' into L_8-question-texts-can-be-too-long-restored
…racters in a text
…ion of Questionares
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
ywarnecke
requested changes
Aug 18, 2026
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Add reusable HtmlUtilities.getVisibleText helper for client-side validation. Show a localized inline error label when the visible question text exceeds the maximum length. Remove the previous alert-based validation and console output. TODO: Reuse this validation in questionnaire/edit and bundle/edit.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…s when going back under limit
Test Results🧪 Unit Test Results🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…eDTOValidator, QuestionnaireDTOValidator and QuestionDTOValidator.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
These copies shadowed the files from src/main/resources/message on the test classpath, because target/test-classes precedes target/classes and classpath: resolves only the first match. As a result, all message keys added since 2026-08-18 were missing during tests, causing NoSuchMessageException for 'questionnaire.error.descriptionTooLong'.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…itation length live validation
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…can-be-too-long-restored # Conflicts: # src/main/resources/message/messages.properties # src/main/resources/message/messages_de_DE.properties # src/main/resources/message/messages_en_GB.properties # src/main/webapp/WEB-INF/bundle/edit.html # src/main/webapp/WEB-INF/question/edit.html # src/test/resources/message/messages.properties # src/test/resources/message/messages_am.properties # src/test/resources/message/messages_de_DE.properties # src/test/resources/message/messages_en_GB.properties # src/test/resources/message/messages_es_ES.properties
ywarnecke
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.