-
Notifications
You must be signed in to change notification settings - Fork 26
Upload improve #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload improve #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- samples/sample-app/views/index.pug: Language not supported
Comments suppressed due to low confidence (3)
test/initialization.js:1
- The removal of initialization tests may reduce test coverage for critical initialization behavior. Consider retaining or migrating at least a subset of these tests to ensure that initialization errors are properly handled.
-const chai = require("chai");
src/url.ts:30
- Setting default empty strings for urlEndpoint and src might mask configuration errors, leading to silent failures in URL generation. It may be beneficial to add explicit validation to ensure that these critical fields are provided.
opts.urlEndpoint = opts.urlEndpoint || "";
rollup.config.js:36
- Changing the export format from default to named exports could break backward compatibility for consumers expecting a default export. Ensure that migration instructions are provided or consider retaining the previous export style if appropriate.
{ file: pkg.main, format: "cjs", exports: "named" },
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 95.45% 91.82% -3.64%
==========================================
Files 9 6 -3
Lines 330 318 -12
Branches 99 102 +3
==========================================
- Hits 315 292 -23
- Misses 4 12 +8
- Partials 11 14 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 24 out of 28 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- .babelrc: Language not supported
- .mocharc.json: Language not supported
- package.json: Language not supported
- samples/sample-app/views/index.pug: Language not supported
…roduce SrcOptions interface for upload functionality
…ription in package.json
…json, fix types location
…json, change imports to type imports
…ge-lock.json, change imports to type imports" This reverts commit 4721a80.
Co-authored-by: Abhinav Dhiman <[email protected]>
Co-authored-by: Abhinav Dhiman <[email protected]>
No description provided.