Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for imagej/imagej-legacy#239 #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tferr
Copy link
Contributor

@tferr tferr commented Feb 19, 2025

This extends #262 further:

  • Ignore Buttons (these are not recordable in ij.gui.GenericDialog, so this change should not carry breaking changes)
  • Ignore ColorTables (these are assigned a value parameter but IJM does not know what to do with it)
  • Ignore inputs tagged w/ ItemVisibility.MESSAGE (as per documentation: this indicated that the item's value is intended as a message to the user rather than an actual parameter to the module execution)

This extends imagej#262 further:
- Ignore Buttons (these are not recordable in ij.gui.GenericDialog, so this change _should_ not carry breaking changes)
- Ignore ColorTables (these are assigned a value parameter but IJM does not know what to do with it)
- Ignore inputs tagged w/ ItemVisibility.MESSAGE  (as per documentation:  this indicated that the item's value is intended as a message to the user rather than an actual parameter to the module execution)
@tferr
Copy link
Contributor Author

tferr commented Feb 19, 2025

@ctrueden: Just to tag you directly in case you are no longer monitoring #239. TLDR; After a quick test this seems to solve macro recording. Tests also run successfully after this. The PR basically merges what had already been proposed by @imagejan and @NicoKiaru in the PTBIOP update site ;)

@tferr
Copy link
Contributor Author

tferr commented Feb 19, 2025

Here is a compiled jar (inside a zip) if some one wants to try:
imagej-legacy-2.0.2-SNAPSHOT.zip

Also, after merging this #239 and #262 could be closed.

tferr added a commit to morphonets/SNT that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant