Skip to content

feat: add loading image from fetching URL #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

EscapedGibbon
Copy link
Collaborator

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Mar 25, 2025 that may be closed by this pull request
@EscapedGibbon EscapedGibbon changed the title feat: add loading image from dataurl url feat: add loading image from fetching dataurl Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (595ca54) to head (8e8e99a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         244      245    +1     
  Lines       10027    10035    +8     
  Branches     2145     2146    +1     
=======================================
+ Hits         9875     9883    +8     
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new method is not exported.

Don't mention "dataurl" in the commit message (just URL).

Otherwise LGTM.

@EscapedGibbon EscapedGibbon changed the title feat: add loading image from fetching dataurl feat: add loading image from fetching URL Mar 25, 2025
@EscapedGibbon EscapedGibbon merged commit bdfff4e into main Mar 25, 2025
9 checks passed
@EscapedGibbon EscapedGibbon deleted the 297-loading-image-from-dataurl-url branch March 25, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading image from dataURL (url)
2 participants