Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing explicit nullable type hint #17

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

daikazu
Copy link
Contributor

@daikazu daikazu commented Jan 14, 2025

Implicitly marking parameter $container as nullable is deprecated in PHP 8.4.

Fixes the PHP 8.4 deprecation where the explicit nullable type must be used.

Deprecated: Illuminatech\UrlTrailingSlash\Router::__construct(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead in vendor/illuminatech/url-trailing-slash/src/Router.php on line 30

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues

…d in PHP 8.4.

Fixes deprecation where implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead.
@klimov-paul klimov-paul self-assigned this Jan 17, 2025
@klimov-paul klimov-paul added the bug Something isn't working label Jan 17, 2025
@klimov-paul klimov-paul merged commit 8a008bf into illuminatech:master Jan 17, 2025
7 checks passed
@klimov-paul klimov-paul added this to the 1.1.13 milestone Jan 17, 2025
@klimov-paul
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants