Skip to content

Replace data-visualization SASS mixin with class #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Replace data-visualization SASS mixin with class #8938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b595613
replaced mixin with class and removed detritus
michaelchadwick Nov 7, 2025
9bd0e0d
rm obsolete include.
stopfstedt Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/frontend/app/components/program-year/visualize-objectives.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import { array } from '@ember/helper';
import t from 'ember-intl/helpers/t';
import VisualizerProgramYearObjectives from 'frontend/components/visualizer-program-year-objectives';
<template>
<section class="program-year-visualize-objectives" data-test-program-year-visualize-objectives>
<section
class="program-year-visualize-objectives data-visualization"
data-test-program-year-visualize-objectives
>
<div class="breadcrumbs" data-test-breadcrumb>
<span>
<LinkTo @route="program-year" @models={{array @model.program @model}}>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/school/session-type-visualize-vocabularies.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import t from 'ember-intl/helpers/t';
import VisualizeSessionTypeVocabulariesGraph from 'frontend/components/school/visualize-session-type-vocabularies-graph';
<template>
<section
class="school-session-type-visualize-vocabularies"
class="school-session-type-visualize-vocabularies data-visualization"
data-test-school-session-type-visualize-vocabularies
...attributes
>
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/app/components/school/session-type-visualize-vocabulary.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import t from 'ember-intl/helpers/t';
import VisualizeSessionTypeVocabularyGraph from 'frontend/components/school/visualize-session-type-vocabulary-graph';
<template>
<section
class="school-session-type-visualize-vocabulary"
class="school-session-type-visualize-vocabulary data-visualization"
data-test-school-session-type-visualize-vocabulary
...attributes
>
Expand Down
3 changes: 0 additions & 3 deletions packages/frontend/app/styles/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@
@forward "components/program-year/objective-list-item-competency";
@forward "components/program-year/objective-list-item-expanded";
@forward "components/program-year/objective-list";
@forward "components/program-year/visualize-objectives";

@forward "components/curriculum-inventory/new-report";
@forward "components/curriculum-inventory/new-sequence-block";
Expand Down Expand Up @@ -139,8 +138,6 @@
@forward "components/reports/subjects";
@forward "components/reports/subjects-list";

@forward "components/school/session-type-visualize-vocabularies";
@forward "components/school/session-type-visualize-vocabulary";
@forward "components/school/visualize-session-type-vocabularies-graph";
@forward "components/school/visualize-session-type-vocabulary-graph";
@forward "components/school/emails";
Expand Down
5 changes: 0 additions & 5 deletions packages/frontend/app/styles/components/program-year/visualize-objectives.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/frontend/app/styles/components/school/session-type-visualize-vocabularies.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/frontend/app/styles/components/school/session-type-visualize-vocabulary.scss
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/ilios-common/addon/components/course/visualizations.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class CourseVisualizationsComponent extends Component {
}
<template>
{{pageTitle (t "general.courses") " | " @model.title " | " (t "general.visualizations")}}
<section class="course-visualizations" data-test-course-visualizations>
<section class="course-visualizations data-visualization" data-test-course-visualizations>
{{#if this.academicYearCrossesCalendarYearBoundariesData.isResolved}}
<div class="breadcrumbs" data-test-breadcrumb>
<span>
Expand Down
5 changes: 4 additions & 1 deletion packages/ilios-common/addon/components/course/visualize-instructor.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ export default class CourseVisualizeInstructorComponent extends Component {
});
}
<template>
<section class="course-visualize-instructor" data-test-course-visualize-instructor>
<section
class="course-visualize-instructor data-visualization"
data-test-course-visualize-instructor
>
<div class="breadcrumbs" data-test-breadcrumb>
<span>
<LinkTo @route="course" @model={{@course}}>
Expand Down
5 changes: 4 additions & 1 deletion packages/ilios-common/addon/components/course/visualize-instructors.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ export default class CourseVisualizeInstructorsComponent extends Component {
(t "general.instructors")
}}

<section class="course-visualize-instructors" data-test-course-visualize-instructors>
<section
class="course-visualize-instructors data-visualization"
data-test-course-visualize-instructors
>
{{#if this.academicYearCrossesCalendarYearBoundariesData.isResolved}}
<div class="breadcrumbs" data-test-breadcrumb>
<span>
Expand Down
5 changes: 4 additions & 1 deletion packages/ilios-common/addon/components/course/visualize-objectives.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export default class CourseVisualizeObjectivesComponent extends Component {
(t "general.objectives")
}}

<section class="course-visualize-objectives" data-test-course-visualize-objectives>
<section
class="course-visualize-objectives data-visualization"
data-test-course-visualize-objectives
>
<div class="breadcrumbs" data-test-breadcrumb>
<span>
<LinkTo @route="course" @model={{@model}}>
Expand Down
5 changes: 4 additions & 1 deletion packages/ilios-common/addon/components/course/visualize-session-type.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ export default class CourseVisualizeSessionTypeComponent extends Component {
: false;
}
<template>
<section class="course-visualize-session-type" data-test-course-visualize-session-type>
<section
class="course-visualize-session-type data-visualization"
data-test-course-visualize-session-type
>
{{#if this.academicYearCrossesCalendarYearBoundariesData.isResolved}}
<div class="breadcrumbs" data-test-breadcrumb>
<span>
Expand Down
5 changes: 4 additions & 1 deletion packages/ilios-common/addon/components/course/visualize-session-types.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ export default class CourseVisualizeSessionTypesComponent extends Component {
(t "general.sessionTypes")
}}

<section class="course-visualize-session-types" data-test-course-visualize-session-types>
<section
class="course-visualize-session-types data-visualization"
data-test-course-visualize-session-types
>
<div class="breadcrumbs" data-test-breadcrumb>
<span>
<LinkTo @route="course" @model={{@model}}>
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/addon/components/course/visualize-term.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class CourseVisualizeTermComponent extends Component {
: false;
}
<template>
<section class="course-visualize-term" data-test-course-visualize-term>
<section class="course-visualize-term data-visualization" data-test-course-visualize-term>
{{#if this.academicYearCrossesCalendarYearBoundariesData.isResolved}}
<div class="breadcrumbs" data-test-breadcrumb>
<span>
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/addon/components/course/visualize-vocabularies.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default class CourseVisualizeVocabulariesComponent extends Component {
}}

<section
class="course-visualize-vocabularies"
class="course-visualize-vocabularies data-visualization"
data-test-course-visualize-vocabularies
...attributes
>
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/addon/components/course/visualize-vocabulary.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default class CourseVisualizeVocabularyComponent extends Component {
}}

<section
class="course-visualize-vocabulary"
class="course-visualize-vocabulary data-visualization"
data-test-course-visualize-vocabulary
...attributes
>
Expand Down
7 changes: 0 additions & 7 deletions packages/ilios-common/app/styles/ilios-common/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,12 @@
@forward "components/course/visualize-instructor";
@forward "components/course/visualize-instructor-session-type-graph";
@forward "components/course/visualize-instructor-term-graph";
@forward "components/course/visualize-instructors";
@forward "components/course/visualize-instructors-graph";
@forward "components/course/visualize-objectives";
@forward "components/course/visualize-objectives-graph";
@forward "components/course/visualize-session-type";
@forward "components/course/visualize-session-type-graph";
@forward "components/course/visualize-session-types";
@forward "components/course/visualize-session-types-graph";
@forward "components/course/visualize-term";
@forward "components/course/visualize-term-graph";
@forward "components/course/visualize-vocabularies";
@forward "components/course/visualize-vocabularies-graph";
@forward "components/course/visualize-vocabulary";
@forward "components/course/visualize-vocabulary-graph";

@forward "components/session/collapsed-objectives";
Expand Down
2 changes: 0 additions & 2 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualizations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../../mixins" as m;

.course-visualizations {
@include m.data-visualization;

.visualizations {
margin-bottom: 1rem;
@include m.for-tablet-and-up {
Expand Down
2 changes: 0 additions & 2 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-instructor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../../mixins" as m;

.course-visualize-instructor {
@include m.data-visualization;

@include m.for-laptop-and-up {
.visualizations {
display: grid;
Expand Down
5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-instructors.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-objectives.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-session-type.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-session-types.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-term.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-vocabularies.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/ilios-common/app/styles/ilios-common/components/course/visualize-vocabulary.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ilios-common/app/styles/ilios-common/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@forward "mixins/media";
@forward "mixins/collapsed-container";
@forward "mixins/critical-notice";
@forward "mixins/data-visualization";
@forward "mixins/detail-container";
@forward "mixins/font-size";
@forward "mixins/graph-with-data-table";
Expand Down
1 change: 1 addition & 0 deletions packages/ilios-common/app/styles/ilios-common/shared.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@forward "shared/data-visualization";
@forward "shared/ilios-zebra-table";
@forward "shared/loading-box";
@forward "shared/loading-shimmer";
Expand Down
6 changes: 3 additions & 3 deletions ...ios-common/mixins/data-visualization.scss → ...ios-common/shared/data-visualization.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "ilios-form";
@use "ilios-heading";
@use "../mixins/ilios-form";
@use "../mixins/ilios-heading";

@mixin data-visualization {
.data-visualization {
h2 {
@include ilios-heading.ilios-heading-h2;
margin: 0.5rem;
Expand Down