Fix GH-20042: SEGV in array.c when error handler clobbers IAP object#6
Closed
Fix GH-20042: SEGV in array.c when error handler clobbers IAP object#6
Conversation
get_ht_for_iap() emits a deprecation notice for object arguments, which can trigger a user error handler that modifies the by-reference variable. After the handler returns, the zval may no longer be an object, causing a segfault when accessing it as one. Re-check the zval type after emitting the deprecation and bail out if it was clobbered.
iliaal
force-pushed
the
fix/gh-20042-iap-object-clobber
branch
from
520b5ff to
905cb37
Compare
Owner
Author
|
Submitted upstream as php#21461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_ht_for_iap()emits a deprecation for object IAP args, triggering the user error handler. If the handler clobbers the by-ref variable, the code reads a dead zval as an object pointer and segfaults.Test plan
.phpttest FAILs on unpatched build, PASSes on patchedext/standard/tests/array/suite: 843/843 passed, 0 regressionsFixes php#20042