-
Notifications
You must be signed in to change notification settings - Fork 41
Adjust upstream versions #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
- Coverage 72.0% 71.8% -0.2%
=======================================
Files 243 242 -1
Lines 19451 19385 -66
=======================================
- Hits 14011 13935 -76
- Misses 5440 5450 +10
🚀 New features to boost your workflow:
|
ee08cae
to
39507b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me and @Wegatriespython all looks good for the water side
- Remove @minimum_activity("message_ix 3.8") and earlier, now mandatory per pyproject.toml. - Remove contents in .util.genno for compatibility with genno <= 1.24; adjust imports. - Remove contents in .util.ixmp for compatibility with ixmp <= 3.7.0; adjust imports.
Since message_ix 3.8 is now the minimum for all of message-ix-models, these are no longer needed.
Add MinimumVersionDecorator class to collect and clarify functionality.
In accordance with the upstream version policy and the release history:
Thus:
Also:
.util.minimum_version()
to handle recursive references to other functions/callables decorated in the same way and thus their minimum version requirements.How to review
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.