Skip to content

Add changes in peer dependencies for RN 64+#35

Open
TheWebartist wants to merge 1 commit into
ihor:masterfrom
TheWebartist:master
Open

Add changes in peer dependencies for RN 64+#35
TheWebartist wants to merge 1 commit into
ihor:masterfrom
TheWebartist:master

Conversation

@TheWebartist

Copy link
Copy Markdown

Since version 64 of react-native, the react version is set to 17 and we have versions mismatch when use react-native-scalable-image. So change react peer dependency and remove prop-types peer dependency

Since version 64 of react-native, the react version is set to 17 and we have versions mismatch when use react-native-scalable-image. So change react peer dependency and remove prop-types peer dependency
@krumware

Copy link
Copy Markdown

Please consider this pull request for merging

@dancherb

Copy link
Copy Markdown

+1, currently impossible to npm install react-native-fit-image in the latest version of RN.

@ajitdas123

Copy link
Copy Markdown

@TheWebartist Why did you remove prop-types from package.json ? isn't it going to cause conflict since it is being used in the package?

@jackkinsella

Copy link
Copy Markdown

There is a fork that already merged this PR here if you need this to work after upgrading RN: https://github.com/uugengiven/react-native-scalable-image

@jrussbautista

Copy link
Copy Markdown

Any updates for this?

@AlkanV

AlkanV commented Aug 18, 2022

Copy link
Copy Markdown

any updates?

@sarbos

sarbos commented May 3, 2023

Copy link
Copy Markdown

I also need this change. Any updates?

@yessinej

yessinej commented Aug 2, 2023

Copy link
Copy Markdown

#41 check this one it might help you , I just got the same problem ( i'm working with react 18 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants