Skip to content

fix: faucet cmd issue #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

fix: faucet cmd issue #4585

merged 3 commits into from
Mar 19, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 19, 2025

Description

The faucet now only works if you pass one coin. If you pass more than one coin or it is empty, it will throw an error.

Solution

The faucet handler calls the bank to send messages through the CLI, passing the coin argument one by one; now, we should pass as an array of coins separated by a comma.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@julienrbrt julienrbrt enabled auto-merge (squash) March 19, 2025 16:41
@julienrbrt julienrbrt merged commit f06431d into main Mar 19, 2025
42 of 47 checks passed
@julienrbrt julienrbrt deleted the fix/faucet-args branch March 19, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants