Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add field max length #4480

Merged
merged 11 commits into from
Feb 7, 2025
Merged

feat: add field max length #4480

merged 11 commits into from
Feb 7, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jan 23, 2025

close #3757

Description

add field max length

@Pantani Pantani self-assigned this Jan 23, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Jan 23, 2025
@Pantani Pantani changed the title feat: add field max lenght feat: add field max length Jan 23, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for this, we should never need a very long name.

However, the linked the issue is about something else (it is about doing length checks of fields in the msg server). Tbh, i don't think we should scaffold what they ask by default.

julienrbrt
julienrbrt previously approved these changes Jan 23, 2025
salmad3
salmad3 previously approved these changes Jan 23, 2025
@Pantani
Copy link
Collaborator Author

Pantani commented Jan 23, 2025

ACK for this, we should never need a very long name.

However, the linked the issue is about something else (it is about doing length checks of fields in the msg server). Tbh, i don't think we should scaffold what they ask by default.

Yes, I got it, and I agree it doesn't make sense to add length to the field. I think we can share some data bigger than this. we can reduce 256 to 20. wdyt?

@Pantani Pantani dismissed stale reviews from salmad3 and julienrbrt via 031880f January 24, 2025 02:00
@Pantani Pantani requested review from salmad3 and julienrbrt January 24, 2025 02:00
salmad3
salmad3 previously approved these changes Jan 31, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@julienrbrt julienrbrt enabled auto-merge (squash) February 7, 2025 16:49
@julienrbrt julienrbrt merged commit b3ab467 into main Feb 7, 2025
42 of 45 checks passed
@julienrbrt julienrbrt deleted the feat/add-field-max-lenght branch February 7, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INIT: Limit Field Length by Default in New Scaffold Modules
3 participants