Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): introduce ignite connect #102

Merged
merged 27 commits into from
Feb 7, 2025
Merged

feat(connect): introduce ignite connect #102

merged 27 commits into from
Feb 7, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 13, 2024

Introducing the Ignite Connect App. This app allows interacting with any cosmos chain for making queries and transactions.
This is the replacement of ignite node, a command in ignite that did basically the above but only for bank queries and transactions, as well as querying transaction hashes. Once this is released, ignite node will be deprecated.

This app is shares the same concepts as Hubl.
However, it doesn't share the same codebase and is better integrated in Ignite for a better UX (supporting ignite account for key management and replacing an existing ignite feature).

@julienrbrt
Copy link
Member Author

Getting back to this 😅

@julienrbrt julienrbrt marked this pull request as ready for review February 1, 2025 00:05
@julienrbrt
Copy link
Member Author

R4R! In a follow-up I'll upgrade the app to use ignite 29 and wired keyring (it is a bit annoying to do that with 0.50 client/v2).

@Pantani
Copy link
Collaborator

Pantani commented Feb 6, 2025

I got an error connecting to Archway (archway.lavenderfive.com:443):

➜  apps git:(julien/connect) ignite connect archway
2025-02-05T21:10:38.454-0300 [ERROR] app /Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect: plugin process exited: plugin=/Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect/connect.ign id=53918 error="exit status 2"
✘ Error reading from server: EOF

@Pantani
Copy link
Collaborator

Pantani commented Feb 6, 2025

the same for atomone

ignite connect atomone                                                                  
2025-02-05T21:15:15.372-0300 [ERROR] app /Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect: plugin process exited: plugin=/Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect/connect.ign id=54296 error="exit status 2"
✘ Error reading from server: EOF

I got an error connecting to Archway (archway.lavenderfive.com:443 and grpc.mainnet.archway.io:443):

➜  apps git:(julien/connect) ignite connect archway
2025-02-05T21:10:38.454-0300 [ERROR] app /Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect: plugin process exited: plugin=/Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect/connect.ign id=53918 error="exit status 2"
✘ Error reading from server: EOF

@Pantani
Copy link
Collaborator

Pantani commented Feb 6, 2025

Sometimes, it takes too long after Selected endpoint: ..... Can we add a spinner?

@julienrbrt
Copy link
Member Author

the same for atomone

ignite connect atomone                                                                  

2025-02-05T21:15:15.372-0300 [ERROR] app /Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect: plugin process exited: plugin=/Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect/connect.ign id=54296 error="exit status 2"

✘ Error reading from server: EOF

I got an error connecting to Archway (archway.lavenderfive.com:443 and grpc.mainnet.archway.io:443):

➜ apps git:(julien/connect) ignite connect archway

2025-02-05T21:10:38.454-0300 [ERROR] app /Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect: plugin process exited: plugin=/Users/danilopantani/Desktop/go/src/github.com/ignite/apps/connect/connect.ign id=53918 error="exit status 2"

✘ Error reading from server: EOF

Yeah, not all endpoints work from the chain registry unfortunately. We should eventually pick preferred ones to show first to improve the UX. Right not you need to try a bit until you find one that works :/
You can try with a local chain as well, if you do connect add simapp localhost:9080.

@julienrbrt julienrbrt requested a review from Pantani February 6, 2025 15:24
@Pantani
Copy link
Collaborator

Pantani commented Feb 6, 2025

Some interactions we can improve

If we try to delete a nonexisting chain, it always shows success, maybe we should show that the chain was not there:
Screenshot 2025-02-06 at 12 40 56

Ignite connect remove shows an error:
Screenshot 2025-02-06 at 12 42 12

Ignite connect add only, tries to add a empty chain:
Screenshot 2025-02-06 at 12 43 13

@julienrbrt
Copy link
Member Author

The last one is expected. I'll improve the other two yes 👍🏾

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 6, 2025

R4R again @Pantani.
About this: #102 (comment), given the uncertainty over 0.52, I am just going to pull in the latest client/v2 in that app, to have the whole logic there. Gives us beter control as well. I'll do that in a follow-up.

Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!! amazing feature

@julienrbrt julienrbrt merged commit 7867ed9 into main Feb 7, 2025
35 checks passed
@julienrbrt julienrbrt deleted the julien/connect branch February 7, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants