Skip to content

Add TSDoc and simplify components [fixes #103] #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add TSDoc and simplify components [fixes #103] #118

wants to merge 2 commits into from

Conversation

zorfling
Copy link
Contributor

While adding the TSDoc I noticed a couple of small issues, so I've fixed those here too.

So this PR:

  • Adds TSDoc to types.ts
  • Fixes use of custom key (it appeared unused in lieu of the name)
  • Adds a story to test custom key
  • Simplify InMenuOptionStuff and OutMenuOptionStuff to use a single component and styled-components to set the color - removes the need for activeClicked on outOptions

Fixes #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Add JSDoc to types.ts
1 participant
@zorfling