Fixed use of compact! (#136)

icub-tech-iit · Apr 5, 2022 · 52e7073 · 52e7073
1 parent fe6326c
commit 52e7073
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 7 deletions.
diff --git a/repos/electronics-boards.yml b/repos/electronics-boards.yml
@@ -14,3 +14,7 @@ electronics-boards:
   andreamerello:
     type: "user"
     permissions: "read"
+
+  augustofranciscoiit:
+    type: "user"
+    permissions: "read"
diff --git a/repos/ergocub-design-joint.yml b/repos/ergocub-design-joint.yml
@@ -6,3 +6,8 @@ ergocub-design-joint:
   hsp-iit/ergocub:
     type: "group"
     permissions: "read"
+
+  augustofranciscoiit:
+    type: "user"
+    permissions: "read"
+
diff --git a/repos/ergocub-design-lowerarm.yml b/repos/ergocub-design-lowerarm.yml
@@ -6,3 +6,8 @@ ergocub-design-lowerarm:
   hsp-iit/ergocub:
     type: "group"
     permissions: "read"
+
+  augustofranciscoiit:
+    type: "user"
+    permissions: "read"
+
diff --git a/repos/mechatronics.yml b/repos/mechatronics.yml
@@ -10,4 +10,7 @@ mechatronics:
   evalli-iit:
     type: "user"
     permissions: "read"
-
+
+  augustofranciscoiit:
+    type: "user"
+    permissions: "read"
diff --git a/repos/teams-repos.yml b/repos/teams-repos.yml
@@ -15,12 +15,12 @@ proto: *template_teams_repos
 
 dev:
   <<: *template_teams_repos
-  AugustoFrancisco:
+  augustofranciscoiit:
     type: "user"
     permissions: "read"
 
 five:
   <<: *template_teams_repos
-  AugustoFrancisco:
+  augustofranciscoiit:
     type: "user"
     permissions: "read"
diff --git a/scripts/check-automated-repositories.rb b/scripts/check-automated-repositories.rb
@@ -62,9 +62,12 @@ def check_user(user, permissions)
 # main
 
 # retrieve information from files
-groups = get_entries("../groups").compact!
+groups = get_entries("../groups")
 repos = get_entries("../repos")
 
+# remove empty groups
+groups.compact!
+
 # cycle over repos
 repos.each { |repo_name, repo_metadata|
     repo_full_name = $org + "/" + repo_name

diff --git a/scripts/delete-invitations.rb b/scripts/delete-invitations.rb
@@ -32,9 +32,12 @@
 # main
 
 # retrieve information from files
-groups = get_entries("../groups").compact!
+groups = get_entries("../groups")
 repos = get_entries("../repos")
 
+# remove empty groups
+groups.compact!
+
 # retrieve input repos 
 repos_input = ENV['OUTSIDE_COLLABORATORS_REPOS_DELETE_INVITATIONS'].split(/\s*,\s*/)
 puts "📃 List of automated repositories to process: #{repos_input}"

diff --git a/scripts/mentioning-comment-handler.rb b/scripts/mentioning-comment-handler.rb
@@ -44,9 +44,12 @@
 puts "- comment_id   = \"#{$comment_id}\""
 
 # retrieve information from files
-groups = get_entries("../groups").compact!
+groups = get_entries("../groups")
 repos = get_entries("../repos")
 
+# remove empty groups
+groups.compact!
+
 # retrieve metadata
 repo_name = $repo.split('/')[-1]
 if repos.key?(repo_name) then

diff --git a/scripts/outside-collaborators-handler.rb b/scripts/outside-collaborators-handler.rb
@@ -138,9 +138,12 @@ def add_repo_collaborator(repo, user, auth)
 # main
 
 # retrieve information from files
-groups = get_entries("../groups").compact!
+groups = get_entries("../groups")
 repos = get_entries("../repos")
 
+# remove empty groups
+groups.compact!
+
 has_errors = false
 
 # cycle over repos