Fix exception when rotating skewed item.#63
Open
jongleur1983 wants to merge 3 commits intoicsharpcode:masterfrom
Open
Fix exception when rotating skewed item.#63jongleur1983 wants to merge 3 commits intoicsharpcode:masterfrom
jongleur1983 wants to merge 3 commits intoicsharpcode:masterfrom
Conversation
This test should be extended later to check the correct output, but first step would be just not to crash.
Author
|
Mentioning you, @jogibear9988 as you answered in the ticket before and "promised" to have a look at the fix: I revoke from fixing the underlying issue in the UI as I fail to get around the overall UI and I don't think I'm going to invest much more time in this project in the next time. I'm happy to change what's necessary when I know what to do, so any hints are welcome. AppVeyor fails for two reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to fix issue #36 - starting with a failing unit test.
The test reproduces the described issue (I hope) and fails as expected, yet by throwing the same exception described by @mnusr
Not sure I'll get a solution, but I'm working on it.
Update: The issue in the demo app is solved.
The unit test doesn't, yet - so I might be doing something wrong there.
But: The demo app has a strange rotation behaviour now - not sure yet how the rotation angle is calculated from mouse input, this might be broken somehow on Skewed items.
I don't think that's based on the changes in this PR, but wasn't just not visible before.