Skip to content

Fix nested namespace directories #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Apr 2, 2025

Resolves #3448

Problem

31bbcf4 introduced a regression, preventing the UseNestedDirectoriesForNamespaces from functioning as intended.

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
    • As part of my testing, I added two API methods to WholeProjectDecompiler.
  • Which part of this PR is most in need of attention/improvement?
    • BamlResourceNodeFactory::WriteResourceToFile also uses this method, which I think is incorrect, but I'm not sure what to change it to.
  • At least one test covering the code changed

@ds5678 ds5678 force-pushed the fix-nested-namespace-directories branch from 6b72f23 to fb560ab Compare April 5, 2025 19:11
@ds5678 ds5678 force-pushed the fix-nested-namespace-directories branch from fb560ab to fb180b0 Compare April 8, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: UseNestedDirectoriesForNamespaces doesn't work anymore
1 participant