-
Notifications
You must be signed in to change notification settings - Fork 61
Add 1.16.1+ new blocks/states #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Added up to before walls, these received many new states: instead of a bool for each direction, its tristate with none/low/tall. |
Owner
Author
|
1.16.1 to 1.16.2 is comparatively simple: Chain adds an axis, Lanterns add waterlogged |
Owner
Author
Owner
Author
|
Again not complete, but at least this fixes some of the block definitions; would have to fix #71 assets first in order to actually render new blocks, so will merge this for now |
iceiix
added a commit
that referenced
this pull request
Jan 15, 2021
Adds _some _new blocks and block states, building on the version- dependent block support added in #469. Notably, fixes grass on 1.16.4. 1.16.1+ (protocol_version >= 735) * Add NetherGoldOre * Add SoulFire * Add SoulSoil, Basalt * Add PolishedBasalt, SoulTorch, SoulWallTorch * Add Chain * 1.16.2+ (protocol_version >= 751) * Add Chain axis states
iceiix
added a commit
that referenced
this pull request
Jan 15, 2021
Adds _some _new blocks and block states, building on the version- dependent block support added in #469. Notably, fixes grass on 1.16.4. 1.16.1+ (protocol_version >= 735) * Add NetherGoldOre * Add SoulFire * Add SoulSoil, Basalt * Add PolishedBasalt, SoulTorch, SoulWallTorch * Add Chain 1.16.2+ (protocol_version >= 751) * Add Chain axis states
iceiix
added a commit
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Building on #469, add additional block and/or block states beyond 1.14+ to fix shifted IDs.
diffs: https://gist.github.com/iceiix/086ed124fd19744140b368d06594a109
1.15 is mostly naming fixes not so much shifts, but 1.16.1 does have shifts we need to handle