Adding another effective area weighting test #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a test for the weighted version of effective area with a lambda function for an E^-2.7 spectrum. Note the pdgid necessary for get_weights()
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 813 813
=========================================
Hits 813 813 ☔ View full report in Codecov by Sentry. |
For the test of weighted effective area, I want to use lambda functions. The calculation of the integral of the flux demands a pdgid argument which however is actually not needed for a primary-independent flux weighting. So pdgid needs to be defined as argument of the flux function but not used which usually ruff would complain about. I hope it's okay when I ignore ARG005
kjmeagher
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test for the weighted version of effective area with a lambda function for an E^-2.7 spectrum. Note the pdgid necessary for get_weights()