HTCondorSubmitter changes for WIPAC #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. submit file savepath in flarestack_scratch for both DESY & WIPAC hosts 2. add make_dir arg in get_outfile_path() 3. when making submit file, if running on WIPAC set make_dir = True for making outfile subdir
|
I think the black related changes should stay in #415 |
This reverts commit 67501ae.
|
Looks reasonable to me! Note for the future: when I touch code that has to do with paths I try to convert the code to use |
mlincett
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our lives simpler and have the submit file written in the flarestack scratch for both DESY & WIPAC. Before, the submit file was saved on the (NPX submit nodes)
/scratch/<username>, so you had to run the script(s) on the submit node itself (which is not advisable). With this change, scripts can run on the cobalts and the jobs can only be manually submitted, or on the submit node itself and submit them manually or automatically. However, there is a caveat in the latter case: theFLARESTACK_SCRATCH_DIRneeds to be set to a path that is accessible by the submit node (ie/data/useron cobalts).Also change how the logdir is made. If jobs are run on DESY, the log, out, and err files are saved in the same directory under
/clusterin the flarestack scratch. So whenget_logfile_pathis called inmake_submit_file()it creates the folder and the path exists when theselect_logdir()is called for the out and err files paths. However, if jobs are run on WIPAC cluster, the logfile path is set to /scratch and the directory underFLARESTACK_SCRATCH_DIR/clusterneeds to be made for the out and err files to be saved. Thus, create it once when callingget_outfile_path()for the stdout file inmake_submit_file, which setscreate_new = Trueinselect_logdir(), and the same dir is used for the stderr file.