Skip to content

Commit

Permalink
update to node 20
Browse files Browse the repository at this point in the history
  • Loading branch information
icecream17 authored Aug 24, 2024
1 parent 6a79ccf commit 89ceb37
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 17 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: '18'
check-latest: false
node-version: 'lts'
cache: yarn

- run: yarn install
Expand Down
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ A simple sudoku solver I made. This is inspired by <https://sudokuwiki.org/>.

[Install node](https://nodejs.org/), it comes with npm.

Try `npm -i npm@latest` to update npm - if there's a "not recognized" error, search stackoverflow about adding node to path.
Try `npm -i npm@latest` to update npm -- if there's a "not recognized" error, search stackoverflow about adding node to path.

`npm -i yarn`

Expand Down Expand Up @@ -53,8 +53,6 @@ You can run `yarn install` and then `yarn npm audit` for the full report.

## Node version

This uses `String.prototype.replaceAll`, so your node version must be `>=15.0.0`.
This project does not seem to use node, but just in case, this uses `String.prototype.replaceAll`, so your node version must be `>=15.0.0`.

If you're on gitpod run `nvm install 16` on each new terminal.

Also, `@types/node` is usually on one of the latest versions. If this is incompatible with an earlier version of node, please post an issue.
Also, `@types/node` is usually on one of the latest versions, since github actions eventually deprecates old versions of node. If `@types/node` is incompatible with an earlier version of node, you can try downgrading the dependency, or post an issue if it doesn't work. Alternatively, if you're on gitpod run `nvm install 16` or higher.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"devDependencies": {
"@types/jest": "^27.0.2",
"@types/node": "^18.0.0",
"@types/node": "^20.0.0",
"@types/react": "^17.0.34",
"@types/react-dom": "^17.0.11",
"eslint-plugin-jest-dom": "^4.0.0",
Expand Down
25 changes: 16 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3804,12 +3804,12 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^18.0.0":
version: 18.19.38
resolution: "@types/node@npm:18.19.38"
"@types/node@npm:^20.0.0":
version: 20.16.1
resolution: "@types/node@npm:20.16.1"
dependencies:
undici-types: ~5.26.4
checksum: 1a2c052e4eccb9f41bb6535b2278a2a6bf33b1e76450ca35a586110d84439ac0111f7889749662330236e15a0e938c6af3a6a8b2f594aee007a7675467c16039
undici-types: ~6.19.2
checksum: 2b8f30f416f5c1851ffa8a13ef6c464a5e355edfd763713c22813a7839f6419a64e27925f9e89c972513d78432263179332f0bffb273d16498233bfdf495d096
languageName: node
linkType: hard

Expand Down Expand Up @@ -5282,9 +5282,9 @@ __metadata:
linkType: hard

"caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30001259, caniuse-lite@npm:^1.0.30001272, caniuse-lite@npm:^1.0.30001280":
version: 1.0.30001587
resolution: "caniuse-lite@npm:1.0.30001587"
checksum: fb50aa9beaaae42f9feae92ce038f6ff71e97510f024ef1bef2666f3adcfd36d6c59e5675442e5fe795575193f71bc826cb7721d4b0f6d763e82d193bea57863
version: 1.0.30001651
resolution: "caniuse-lite@npm:1.0.30001651"
checksum: c31a5a01288e70cdbbfb5cd94af3df02f295791673173b8ce6d6a16db4394a6999197d44190be5a6ff06b8c2c7d2047e94dfd5e5eb4c103ab000fca2d370afc7
languageName: node
linkType: hard

Expand Down Expand Up @@ -13169,7 +13169,7 @@ resolve@^2.0.0-next.3:
"@testing-library/react": ^12.1.2
"@testing-library/user-event": ^13.5.0
"@types/jest": ^27.0.2
"@types/node": ^18.0.0
"@types/node": ^20.0.0
"@types/react": ^17.0.34
"@types/react-dom": ^17.0.11
eslint-plugin-jest-dom: ^4.0.0
Expand Down Expand Up @@ -14183,6 +14183,13 @@ resolve@^2.0.0-next.3:
languageName: node
linkType: hard

"undici-types@npm:~6.19.2":
version: 6.19.8
resolution: "undici-types@npm:6.19.8"
checksum: de51f1b447d22571cf155dfe14ff6d12c5bdaec237c765085b439c38ca8518fc360e88c70f99469162bf2e14188a7b0bcb06e1ed2dc031042b984b0bb9544017
languageName: node
linkType: hard

"unicode-canonical-property-names-ecmascript@npm:^2.0.0":
version: 2.0.0
resolution: "unicode-canonical-property-names-ecmascript@npm:2.0.0"
Expand Down

0 comments on commit 89ceb37

Please sign in to comment.