Skip to content

Fix compilation errors for 1110 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compilation errors for 1110 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dump/pldm_oem_cmds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ void newFileAvailable(uint32_t dumpId, pldm_fileio_file_type pldmDumpType,
log<level::INFO>(
fmt::format("encode_new_file_req Instance ID ({}) "
"DumpID ({}) DumpType ({}) DumpSize({}) ReqMsgSize({})",
pldmInstanceId, dumpId, pldmDumpType, dumpSize,
newFileAvailReqMsg.size())
pldmInstanceId, dumpId, static_cast<uint8_t>(pldmDumpType),
dumpSize, newFileAvailReqMsg.size())
.c_str());
int retCode = encode_new_file_req(
pldmInstanceId, pldmDumpType, dumpId, dumpSize,
Expand All @@ -82,7 +82,7 @@ void newFileAvailable(uint32_t dumpId, pldm_fileio_file_type pldmDumpType,
fmt::format(
"Failed to encode pldm New file req for new dump available "
"dumpId({}), pldmDumpType({}),rc({})",
dumpId, pldmDumpType, retCode)
dumpId, static_cast<uint8_t>(pldmDumpType), retCode)
.c_str());
elog<NotAllowed>(Reason(
"Acknowledging new file request failed due to encoding error"));
Expand All @@ -100,8 +100,8 @@ void newFileAvailable(uint32_t dumpId, pldm_fileio_file_type pldmDumpType,
"Failed to send pldm new file request for new dump available, "
"dumpId({}), pldmDumpType({}), "
"rc({}), errno({}), errmsg({})",
dumpId, pldmDumpType, retCode, errorNumber,
strerror(errorNumber))
dumpId, static_cast<uint8_t>(pldmDumpType), retCode,
errorNumber, strerror(errorNumber))
.c_str());
elog<NotAllowed>(Reason("New file available via pldm is not "
"allowed due to new file request send failed"));
Expand Down
5 changes: 3 additions & 2 deletions dump/pldm_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ int openPLDM()
if (fd < 0)
{
auto e = errno;
log<level::ERR>(
fmt::format("pldm_open failed, errno({}), FD({})", e, fd).c_str());
log<level::ERR>(fmt::format("pldm_open failed, errno({}), FD({})", e,
static_cast<int>(fd))
.c_str());
elog<NotAllowed>(Reason("Required host dump action via pldm is not "
"allowed due to pldm_open failed"));
}
Expand Down