Skip to content

VPD:Add DefaultError entry in PEL registry #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1110
Choose a base branch
from
Open

VPD:Add DefaultError entry in PEL registry #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f763075
Fix clang issues
PriyangaRamasamy Feb 5, 2025
91ae40d
VPD:Add DefaultError entry in PEL registry
PriyangaRamasamy Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions extensions/openpower-pels/registry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,9 @@ to use in addition to the ASCII string field to form the symptom ID. All words
are separated by underscores. If not specified, the code will choose a default
format, which may depend on the SRC type.

For example: ["SRCWord3", "SRCWord9"] would be: `<ASCII_STRING>_<SRCWord3>_<SRCWord9>`,
which could look like: `B181320_00000050_49000000`.
For example: ["SRCWord3", "SRCWord9"] would be:
`<ASCII_STRING>_<SRCWord3>_<SRCWord9>`, which could look like:
`B181320_00000050_49000000`.

```json
"SymptomIDFields": ["SRCWord3", "SRCWord9"]
Expand Down
35 changes: 35 additions & 0 deletions extensions/openpower-pels/registry/message_registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4874,6 +4874,41 @@
}
},

{
"Name": "com.ibm.VPD.Error.DefaultError",
"Subsystem": "cec_vpd",

"SRC": {
"ReasonCode": "0x4000",
"Words6To9": {}
},

"Callouts": [
{
"CalloutList": [
{ "Priority": "high", "Procedure": "BMC0001" }
]
}
],

"Documentation": {
"Description": "This entry is used when no other matching VPD error is found",
"Message": "Unknown VPD error occurred. (Original event not in message registry)",
"Notes": [
"This is used when actual cause of the VPD falure is unknown.",
"This error may contain callouts if the creator passed ",
"them in.",
"The severity is set by the creator.",
"If this error is seen, then a VPD code change needs to be ",
"made to log the specific error type related to the issue."
]
},

"JournalCapture": {
"NumLines": 30
}
},

{
"Name": "com.ibm.VPD.Error.InvalidEepromPath",
"Subsystem": "cec_vpd",
Expand Down
8 changes: 4 additions & 4 deletions log_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,10 @@ void Manager::_commit(uint64_t transactionId [[maybe_unused]],
createEntry(errMsg, errLvl, additionalData);
}

auto Manager::createEntry(
std::string errMsg, Entry::Level errLvl,
std::vector<std::string> additionalData,
const FFDCEntries& ffdc) -> sdbusplus::message::object_path
auto Manager::createEntry(std::string errMsg, Entry::Level errLvl,
std::vector<std::string> additionalData,
const FFDCEntries& ffdc)
-> sdbusplus::message::object_path
{
if (!Extensions::disableDefaultLogCaps())
{
Expand Down