Skip to content

fix: Updated Node packages to fix CVEs #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bundle/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
2 changes: 1 addition & 1 deletion .github/actions/commenter/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
2 changes: 1 addition & 1 deletion .github/actions/coverage-report/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ COPY package-lock.json .

RUN npm install

ENTRYPOINT ["node", "/index.js"];
ENTRYPOINT ["node", "/index.js"]
30 changes: 15 additions & 15 deletions .github/workflows/node-pr-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ jobs:
run:
working-directory: ui
steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
uses: actions/setup-node@v1
- uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 18.x
- name: Install Dependencies
run: npm ci
- name: Build
run: npm run build
- name: Caluclate bundle size
- name: Calculate bundle size
id: bundle
uses: ./.github/actions/bundle
- name: Test
Expand All @@ -47,34 +47,34 @@ jobs:
working-directory: ui

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
uses: actions/setup-node@v1
- uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 18.x
- name: Install Dependencies
run: npm ci
- name: Code lint
run: npm run lint

e2e-tests:
runs-on: ubuntu-latest # or macos-latest, windows-latest
runs-on: ubuntu-22.04 # or macos-latest, windows-latest
defaults:
run:
working-directory: ui
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Increase file watcher limit
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 12.x
- uses: microsoft/playwright-github-action@v1
node-version: 18.x
- uses: microsoft/playwright-github-action@v1.0.0
- name: Install dependencies
run: npm ci
- name: run tests
run: npm run test:e2e
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: failures
Expand Down
4 changes: 2 additions & 2 deletions ui/e2e/testEnvironment.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* SPDX-License-Identifier: Apache-2.0
*/
const { mkdir } = require('fs').promises;
const PlaywrightEnvironment = require('jest-playwright-preset/lib/PlaywrightEnvironment')
.default;
const PlaywrightEnvironment =
require('jest-playwright-preset/lib/PlaywrightEnvironment').default;
const { saveVideo } = require('playwright-video');

class CustomEnvironment extends PlaywrightEnvironment {
Expand Down
Loading
Loading