fix(interactive-repr): ensure that null scalars can be repr'd interactively #10784
+86
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
changed the title
github-actions
bot
added
tests
|
This is going to fail with lots of crashing until the next version of DuckDB is released. DuckDB 1.1.3 had some issues with converting bigger fixed length arrays to arrow. |
cpcloud
force-pushed
the
fix-null-scalar-interactive-repr
branch
from
6a3a5f5 to
a3d8de2
Compare
|
I'll reduce the test case here to limit the upper bound of fixed length arrays, so that we can get this merged for 10.0. After all, the thing being fixed and tested here is not arrow conversion, but |
cpcloud
force-pushed
the
fix-null-scalar-interactive-repr
branch
4 times, most recently
from
3fccc90 to
15b4a61
Compare
cpcloud
force-pushed
the
fix-null-scalar-interactive-repr
branch
from
15b4a61 to
7512cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10780.