Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphviz): ensure all lines are left-justified #10783

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

deepyaman
Copy link
Contributor

Description of changes

Make sure the last lines of multi-line labels are left-justified (not centered) by adding a trailing left-aligned break.

Solution: https://stackoverflow.com/q/49568399

Before

image

After

image

@deepyaman deepyaman requested review from cpcloud and gforsyth February 4, 2025 06:27
@deepyaman deepyaman added this to the 10.0 milestone Feb 4, 2025
@deepyaman
Copy link
Contributor Author

Added to 10.0 milestone because it seems like a pretty trivial fix/improvement to sneak in.

@cpcloud cpcloud added the graphviz Issues or PRs related to visualizing ibis expresssions using graphviz label Feb 4, 2025
@cpcloud
Copy link
Member

cpcloud commented Feb 4, 2025

Thanks!

@cpcloud cpcloud merged commit 3e86e2d into ibis-project:main Feb 4, 2025
89 checks passed
@deepyaman deepyaman deleted the left-justify-labels branch February 4, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphviz Issues or PRs related to visualizing ibis expresssions using graphviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants