Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(duckdb): test against the latest duckdb pre-release #10776

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ibis/backends/duckdb/tests/test_udf.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@

def test_builtin_scalar_noargs(con):
@udf.scalar.builtin
def version() -> str: ...
def current_schema() -> str: ...

expr = version()
assert con.execute(expr) == f"v{con.version}"
expr = current_schema()
assert con.execute(expr) == con.current_database

Check warning on line 60 in ibis/backends/duckdb/tests/test_udf.py

View check run for this annotation

Codecov / codecov/patch

ibis/backends/duckdb/tests/test_udf.py#L59-L60

Added lines #L59 - L60 were not covered by tests


@udf.agg.builtin
Expand Down
7 changes: 2 additions & 5 deletions ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,11 +476,8 @@ def mean_and_std(v):
lambda t, where: t.string_col[where].nunique(),
id="approx_nunique",
marks=[
pytest.mark.xfail_version(
duckdb=["duckdb>=1.1"],
raises=AssertionError,
reason="not exact, even at this tiny scale",
strict=False,
pytest.mark.notyet(
["duckdb"], raises=AssertionError, reason="not exact", strict=False
),
pytest.mark.notimpl(
["datafusion"],
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ druid = [
"rich>=12.4.4,<14",
]
duckdb = [
"duckdb>=0.10,<1.2",
"duckdb>=1.1.4.dev5147",
"pyarrow>=10.0.1",
"pyarrow-hotfix>=0.4,<1",
"numpy>=1.23.2,<3",
Expand Down
14 changes: 7 additions & 7 deletions requirements-dev.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading