Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add udf rewriting blog post #10763

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

hussainsultan
Copy link
Contributor

Description of changes

Add a blog post detailing the experience of adding and rewriting a UDF using Ibis. The use-case is to perform predicate pushdown on a special UDF that is capable of running and pruning XGBoost trees.

Zulip chat: predicate pushdown mechanism that works on XGBoost/GBM models

Issues closed

None

@github-actions github-actions bot added the docs Documentation related issues or PRs label Jan 31, 2025
@hussainsultan hussainsultan force-pushed the blog/ibis-udf-rewriting branch 3 times, most recently from 7a48b0a to 0e565e1 Compare February 3, 2025 18:51
@hussainsultan
Copy link
Contributor Author

@IndexSeek Ready for your review, when you get a chance. Thank you.

@IndexSeek IndexSeek added the docs-preview Add this label to trigger a docs preview label Feb 3, 2025
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 3, 2025
@IndexSeek
Copy link
Member

This looks great, @hussainsultan! I just proofread and gave some grammatical feedback. I tried quickgrove the other day, and it worked well!

We usually try not to exceed 90 characters per line to make it easier to review/edit, could you wrap those? (https://ibis-project.org/contribute/03_style#text-formatting)

@hussainsultan
Copy link
Contributor Author

I just wrapped text lines and also changed to using sentence case for headers.

You mentioned that you left some comments; I am not seeing any comments in this PR yet. Just let me know and I will be happy to make any other changes. Thank you.

@hussainsultan hussainsultan force-pushed the blog/ibis-udf-rewriting branch 3 times, most recently from 5bab0b5 to f172ccd Compare February 4, 2025 15:38
Copy link
Member

@IndexSeek IndexSeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I never submitted the feedback! It looks like it has been outdated now, let me re-update!

docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
@IndexSeek IndexSeek added the docs-preview Add this label to trigger a docs preview label Feb 4, 2025
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 4, 2025
@hussainsultan
Copy link
Contributor Author

I believe I addressed all comments and thank you @IndexSeek

@hussainsultan hussainsultan force-pushed the blog/ibis-udf-rewriting branch from 68aca09 to 4a4a778 Compare February 6, 2025 17:37
Copy link
Member

@IndexSeek IndexSeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thanks for wrapping everything. I really like the story this tells and I tried it the other day, it worked great!

docs/posts/udf-rewriting/index.qmd Outdated Show resolved Hide resolved
@cpcloud
Copy link
Member

cpcloud commented Feb 7, 2025

I fixed the lint failure, so this should be good to go. I'll merge early next week, let's say Wednesday (?) if that's alright with everyone.

@cpcloud cpcloud force-pushed the blog/ibis-udf-rewriting branch from 0713806 to 96751b1 Compare February 12, 2025 11:20
@cpcloud cpcloud force-pushed the blog/ibis-udf-rewriting branch from 96751b1 to 3b2b2b1 Compare February 12, 2025 11:20
@cpcloud cpcloud added the blog Posts for the Ibis blog. label Feb 12, 2025
@cpcloud cpcloud merged commit c6ecf6b into ibis-project:main Feb 12, 2025
27 checks passed
@cpcloud
Copy link
Member

cpcloud commented Feb 12, 2025

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Posts for the Ibis blog. docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants