-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add udf rewriting blog post #10763
docs: add udf rewriting blog post #10763
Conversation
7a48b0a
to
0e565e1
Compare
@IndexSeek Ready for your review, when you get a chance. Thank you. |
This looks great, @hussainsultan! I just proofread and gave some grammatical feedback. I tried quickgrove the other day, and it worked well! We usually try not to exceed 90 characters per line to make it easier to review/edit, could you wrap those? (https://ibis-project.org/contribute/03_style#text-formatting) |
I just wrapped text lines and also changed to using sentence case for headers. You mentioned that you left some comments; I am not seeing any comments in this PR yet. Just let me know and I will be happy to make any other changes. Thank you. |
5bab0b5
to
f172ccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I never submitted the feedback! It looks like it has been outdated now, let me re-update!
I believe I addressed all comments and thank you @IndexSeek |
68aca09
to
4a4a778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thanks for wrapping everything. I really like the story this tells and I tried it the other day, it worked great!
I fixed the lint failure, so this should be good to go. I'll merge early next week, let's say Wednesday (?) if that's alright with everyone. |
0713806
to
96751b1
Compare
96751b1
to
3b2b2b1
Compare
Great work, thank you! |
Description of changes
Add a blog post detailing the experience of adding and rewriting a UDF using Ibis. The use-case is to perform predicate pushdown on a special UDF that is capable of running and pruning XGBoost trees.
Zulip chat: predicate pushdown mechanism that works on XGBoost/GBM models
Issues closed
None